Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dubbo-3669]do local export before register any listener. #3685

Merged
merged 5 commits into from
May 16, 2019
Merged

[Dubbo-3669]do local export before register any listener. #3685

merged 5 commits into from
May 16, 2019

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

Fixes #3669

Brief changelog

RegistryProtocol.export()

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Mar 18, 2019 •
edited
Loading

Codecov Report

Merging #3685 into master will decrease coverage by 0.46%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3685      +/-   ##
============================================
- Coverage     63.44%   62.97%   -0.47%     
- Complexity       71      543     +472     
============================================
  Files           703      756      +53     
  Lines         31000    32581    +1581     
  Branches       5024     5164     +140     
============================================
+ Hits          19669    20519     +850     
- Misses         9066     9706     +640     
- Partials       2265     2356      +91
Impacted Files Coverage Δ Complexity Δ
...stry/integration/AbstractConfiguratorListener.java 27.58% <0%> (-3.19%) 0 <0> (ø)
...va/org/apache/dubbo/rpc/support/AccessLogData.java 0% <0%> (-90.15%) 0% <0%> (ø)
...ava/org/apache/dubbo/common/utils/ClassHelper.java 0% <0%> (-69.1%) 0% <0%> (ø)
...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java 18.05% <0%> (-65.28%) 0% <0%> (ø)
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java 50% <0%> (-18.43%) 0% <0%> (ø)
...notation/ReferenceAnnotationBeanPostProcessor.java 82.66% <0%> (-11.7%) 0% <0%> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 16% <0%> (+16%)
...va/org/apache/dubbo/rpc/support/ProtocolUtils.java 72% <0%> (-6.27%) 0% <0%> (ø)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
...ache/dubbo/config/spring/util/AnnotationUtils.java 29.87% <0%> (-5.2%) 0% <0%> (ø)
... and 279 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bfbc7...2c17623. Read the comment docs.

@ralf0131
Copy link
Contributor

Can you please describe what is the root cause of this exception? This will help the reviewers to understand how you fix it.

@chickenlj chickenlj requested a review from ralf0131 May 14, 2019 06:28
ralf0131
ralf0131 requested changes May 16, 2019
View reviewed changes
Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the logic in org.apache.dubbo.registry.integration.AbstractConfiguratorListener#process as well since they are duplicate?

@chickenlj
Copy link
Contributor Author

Could you change the logic in org.apache.dubbo.registry.integration.AbstractConfiguratorListener#process as well since they are duplicate?

Good point, I will fix it.

ralf0131
ralf0131 approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@ralf0131 ralf0131 merged commit 4ef74fa into apache:master May 16, 2019
@dubbo-bot dubbo-bot mentioned this pull request May 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralf0131 ralf0131 ralf0131 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java.lang.IllegalStateException: error state, exporter should not be null
3 participants
@chickenlj @codecov-io @ralf0131